Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested models + related fixes #1473

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Jan 23, 2024

No description provided.

@pep8speaks
Copy link

Hello @dmach! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 136:57: E721 do not compare types, use 'isinstance()'
Line 147:54: E721 do not compare types, use 'isinstance()'
Line 354:121: E501 line too long (139 > 120 characters)
Line 359:121: E501 line too long (152 > 120 characters)

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (472a56f) 31.24% compared to head (7903ade) 31.38%.
Report is 3 commits behind head on master.

Files Patch % Lines
osc/util/models.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1473      +/-   ##
==========================================
+ Coverage   31.24%   31.38%   +0.13%     
==========================================
  Files          49       49              
  Lines       17826    17859      +33     
==========================================
+ Hits         5570     5605      +35     
+ Misses      12256    12254       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmach dmach merged commit 0103634 into openSUSE:master Jan 23, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants