Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable preinstall images in rootless builds #1444

Merged

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Nov 2, 2023

No description provided.

@pep8speaks
Copy link

Hello @dmach! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1133:121: E501 line too long (122 > 120 characters)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c790134) 30.75% compared to head (3d20497) 30.75%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
- Coverage   30.75%   30.75%   -0.01%     
==========================================
  Files          49       49              
  Lines       17742    17744       +2     
==========================================
  Hits         5457     5457              
- Misses      12285    12287       +2     
Files Coverage Δ
osc/__init__.py 100.00% <100.00%> (ø)
osc/commandline.py 19.08% <0.00%> (ø)
osc/build.py 6.55% <14.28%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmach dmach merged commit 503cf10 into openSUSE:master Nov 3, 2023
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants