Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiurl_aliases handling in OscOptions.__getitem__ #1440

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Oct 23, 2023

Fixes: #1439

@dmach dmach force-pushed the fix-apiurl_aliases branch from 9910d93 to 6fb84de Compare October 23, 2023 21:51
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a2e7383) 30.74% compared to head (c790134) 30.75%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   30.74%   30.75%           
=======================================
  Files          49       49           
  Lines       17740    17742    +2     
=======================================
+ Hits         5455     5457    +2     
  Misses      12285    12285           
Files Coverage Δ
osc/__init__.py 100.00% <100.00%> (ø)
osc/commandline.py 19.08% <0.00%> (ø)
osc/conf.py 54.67% <80.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pallaswept
Copy link

pallaswept commented Oct 28, 2023

Tested this and it fixes the issue for me. For reference: #1439 (comment)

Thanks @dmach !

@dmach dmach merged commit a68377a into openSUSE:master Oct 29, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'apiurl_aliases'
2 participants