Fix retrieving config values in core.vc_export_env() #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing if 'user' config value is present is not necessary, because the 'username' field is mandatory in HostOptions and there is also a check that prompts user to enter new credentials if user is not set.
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-13 18:34:39 UTC |
dmach
force-pushed
the
fix-vc_export_env
branch
from
12d9813 to
2684247
Compare
dmach
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
+ Coverage 30.40% 30.60% +0.20%
==========================================
Files 49 49
Lines 17712 17710 -2
==========================================
+ Hits 5385 5421 +36
+ Misses 12327 12289 -38
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.