Support installing osc into virtualenv #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
==========================================
+ Coverage 30.75% 30.76% +0.01%
==========================================
Files 49 49
Lines 17744 17754 +10
==========================================
+ Hits 5457 5462 +5
- Misses 12287 12292 +5
☔ View full report in Codecov by Sentry. |
dcermak
reviewed
Oct 13, 2023
| @@ -10056,6 +10064,9 @@ def do_comment(self, subcmd, opts, *args): | |||
| print(result) | |||
|
|
|||
| def _load_plugins(self): | |||
There was a problem hiding this comment.
Maybe print a big fat warning here?
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
dcermak
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.