-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use typeguard during tests and in osc-wrapper.py #1424
base: master
Are you sure you want to change the base?
Conversation
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-13 13:20:53 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 31.47% 31.26% -0.21%
==========================================
Files 103 49 -54
Lines 19070 17820 -1250
==========================================
- Hits 6002 5572 -430
+ Misses 13068 12248 -820 ☔ View full report in Codecov by Sentry. |
53d81f0
to
34731ee
Compare
6cbad76
to
21e78e0
Compare
@@ -30,6 +30,13 @@ | |||
%bcond_with fdupes | |||
%endif | |||
|
|||
# use typeguard during build on distros where typeguard is available | |||
%if (0%{?suse_version} > 1500 || 0%{?fedora} >= 37) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to care about Fedora 36 and older
%if (0%{?suse_version} > 1500 || 0%{?fedora} >= 37) | |
%if (0%{?suse_version} > 1500 || 0%{?fedora}) |
No description provided.