Rootless kvm and podman #1415
Merged
Rootless kvm and podman #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-09-29 07:55:28 UTC |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
=======================================
Coverage 30.38% 30.38%
=======================================
Files 49 49
Lines 17698 17701 +3
=======================================
+ Hits 5377 5379 +2
- Misses 12321 12322 +1
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dmach
force-pushed
the
rootless-kvm-and-podman
branch
from
2ff7aaf to
eba7f84
Compare
The current conf.get_config() function already handles loading from ENV. Also, always use osc.build.calculate_build_root() instead of making a custom variable substitution.
…vm types To avoid filesystem permission collisions with the builds using su_wrapper, use an alternative buildroot path that appends username to '/var/tmp/build-root' for the rootless builds.
…uild and osc --vm-type option
dmach
force-pushed
the
rootless-kvm-and-podman
branch
from
eba7f84 to
41ce932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1410
Requires: openSUSE/obs-build#954