fix crash when settings like realname are not set. #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise:
File "/usr/lib/python3.11/site-packages/osc/core.py", line 451, in execute
result = self._execute(dir, old_dir, callmode, singleservice, verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/osc/core.py", line 493, in _execute
vc_export_env(self.apiurl)
File "/usr/lib/python3.11/site-packages/osc/core.py", line 8917, in vc_export_env
os.environ[env] = val
~~~~~~~~~~^^^^^
File "<frozen os>", line 684, in __setitem__
File "<frozen os>", line 758, in encode
TypeError: str expected, not NoneType
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1405 +/- ##
==========================================
- Coverage 30.35% 30.35% -0.01%
==========================================
Files 49 49
Lines 17685 17686 +1
==========================================
Hits 5368 5368
- Misses 12317 12318 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise:
File "/usr/lib/python3.11/site-packages/osc/core.py", line 451, in execute
result = self._execute(dir, old_dir, callmode, singleservice, verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/osc/core.py", line 493, in _execute
vc_export_env(self.apiurl)
File "/usr/lib/python3.11/site-packages/osc/core.py", line 8917, in vc_export_env
os.environ[env] = val
~~~~~~~~~~^^^^^
File "", line 684, in setitem
File "", line 758, in encode
TypeError: str expected, not NoneType