Allow repository name change via git scm basename paramter #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 28, 2023
TarSCM/cli.py
Outdated
| parser.add_argument('--basename', default = None, | ||
| help='Checkout/rename and further process repository as ' | ||
| '<BASENAME> (requires git scm).' | ||
| 'Make sure there are no leftovers (workrepo, obsinfo' |
There was a problem hiding this comment.
line too long (81 > 79 characters)
TarSCM/cli.py
Outdated
| @@ -194,6 +195,11 @@ def parse_args(self, options): | |||
| '(only used with \'--latest-signed-*\')') | |||
| parser.add_argument('--without-version', default = False, | |||
| help='Do not add version to output file.') | |||
| parser.add_argument('--basename', default = None, | |||
| help='Checkout/rename and further process repository as ' | |||
There was a problem hiding this comment.
line too long (85 > 79 characters)
houndci-bot
reviewed
Aug 1, 2023
TarSCM/cli.py
Outdated
| @@ -194,6 +195,11 @@ def parse_args(self, options): | |||
| '(only used with \'--latest-signed-*\')') | |||
| parser.add_argument('--without-version', default = False, | |||
| help='Do not add version to output file.') | |||
| parser.add_argument('--basename', default = None, | |||
| help='Checkout/rename and further process repository ' | |||
Example: https://github.com/DMTF/Redfishtool.git vs network:utilities/redfishtool In mainline project the first letter 'R' is uppercase, but in OBS it's lowercase. Adding basename= parameter in _service file with this patch like: <param name="revision">main</param> <param name="versionformat">@PARENT_TAG@.@[email protected]%h</param> <param name="changesgenerate">enable</param> - </service> + <param name="basename">redfishtool</param> + </service> <service name="set_version" mode="localonly"/> <service name="tar" mode="buildtime"> </service> results in: redfishtool redfishtool-1.1.7.1.gfaa99dc.obscpio redfishtool-1.1.7.1.gfaa99dc.tar.xz redfishtool.obsinfo instead of (without basename param): Redfishtool Redfishtool-1.1.7.1.gfaa99dc.obscpio Redfishtool-1.1.7.1.gfaa99dc.tar.xz Redfishtool.obsinfo With this patch it is possible to adopt or rename any arbitrary git project name to its matching OBS project name and process it via OBS services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
https://github.com/DMTF/Redfishtool.git
vs
network:utilities/redfishtool
In mainline project the first letter 'R' is
uppercase, but in OBS it's lowercase.
Adding basename= parameter in _service file with this patch like:
main
@PARENT_TAG@.@[email protected]%h
enable
results in:
redfishtool
redfishtool-1.1.7.1.gfaa99dc.obscpio
redfishtool-1.1.7.1.gfaa99dc.tar.xz
redfishtool.obsinfo
instead of (without basename param):
Redfishtool
Redfishtool-1.1.7.1.gfaa99dc.obscpio
Redfishtool-1.1.7.1.gfaa99dc.tar.xz
Redfishtool.obsinfo
With this patch it is possible to adopt or rename
any arbitrary git project name to its matching OBS project name and process it via OBS services.