Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TarScm (cpio): fix symlink time stamps #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mwilck
Copy link
Contributor

@mwilck mwilck commented Dec 3, 2021

Symlinks in .obscpio archives don't have the source time stamp. This
may cause non-reproducible .obscpio files.
Fix this by using the "follow_symlinks" option of os.utime().

Symlinks in .obscpio archives don't have the source time stamp. This
may cause non-reproducible .obscpio files.
Fix this by using the "follow_symlinks" option of os.utime().
@mwilck
Copy link
Contributor Author

mwilck commented Dec 6, 2021

FTR, the CI failure doesn't seem to be caused by my patch.

@mwilck
Copy link
Contributor Author

mwilck commented Dec 14, 2021

ping...

@mwilck
Copy link
Contributor Author

mwilck commented Jan 11, 2022

ping…

@M0ses
Copy link
Collaborator

M0ses commented Jan 12, 2022

Pong - Could you provide a test case?

@mwilck
Copy link
Contributor Author

mwilck commented Jan 12, 2022

Sorry, this is not how it works. I'm providing a bug fix, and a rather obvious one for that matter. Rather than saying "thank you", you're asking me to invest more work into your project. I have no time for that, so either take it or leave it.

If you need a sample .obscpio file, see https://build.opensuse.org/package/show/Base:System/multipath-tools, which contains

lrwxrwxrwx   1 root     root           17 Jan  7 21:55 multipath-tools-0.8.8+13+suse.79c3556f/COPYING -> LICENSES/LGPL-2.0

This symlink causes osc service manualrun to create a cpio archive with a different checksum every time it's being run, because the time stamp differs. My patch avoids that in a trivial way by using the time stamp of the symlink's target rather than the time stamp of the symlink itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants