Mitigate Name clash on extract / fix cache handling #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package may contain a file with the same name as the package. In this case, this file cannot be extracted, as the repository directory is already there. Append '_service' to the name of the directory to clone to to avoid this trap. Save the name of this directory for later use in obsinfo. Make sure to remain backward compatible: retain the old behavior if scmdir is not set in obsinfo. Signed-off-by: Egbert Eich <[email protected]>
Signed-off-by: Egbert Eich <[email protected]>
If a cache directory is used, the 'tar' service fails as the URL hash cannot be determined. Check for this and don't use the URL hash. Signed-off-by: Egbert Eich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches resolve two separate issues:
The new name of the package is stored in the obsinfo data. For backward compatibility the code falls back to the old behavior if this entry doesn't exist.
This addresses the issue pointed out in the comment to commit: 9f923f8