add an option to choose what to replace non iso characters with #189
Conversation
nmorey
force-pushed
the
dev/iso-cleanup-string
branch
2 times, most recently
from
034b5b0 to
781ecc5
Compare
|
Thanks a lot for the submission! Your change makes a lot of sense. Please could you extend the PR to include tests for your changes, as per the CONTRIBUTING guide? Thanks again! |
nmorey
force-pushed
the
dev/iso-cleanup-string
branch
2 times, most recently
from
0abfeba to
b79fa5e
Compare
|
@aspiers Here you go :) |
tar_scm.service.in
Outdated
| @@ -153,4 +153,7 @@ which get maintained in the SCM. Can be used multiple times.</description> | |||
| <parameter name="changesauthor"> | |||
| <description>Specify author of the changes file entry to be written. Defaults to first email entry in ~/.oscrc, or "[email protected]" if there is no .oscrc found.</description> | |||
| </parameter> | |||
| <parameter name="iso-cleanup-string"> | |||
| <description>Characters [-:] are replace by this string. Defaults to ''.</description> | |||
|
I was wondering, why you call minus and colon "non-iso" characters? |
Some upstream repos use annoying version format like: 10.2-63. When running through the service, : and - are deleted which generates unusable/misleading version strings (10.263). This patches adds an option (iso-cleanup-string) which allows to choose which charater/string to use to replace the non iso ones. Default value is '' which keeps the legacy behaviour. For example 10.2-63 with iso-cleanup-string='.' will generate 10.2.63 Signed-off-by: Nicolas Morey-Chaisemartin <[email protected]>
nmorey
force-pushed
the
dev/iso-cleanup-string
branch
from
b79fa5e to
e313aaf
Compare
|
@aspiers done @bmwiedemann THe function that cleans these is call ise_cleanup_str |
Actually it was called
Effectively, yes. The "ISO" part came from a reference to the function reformatting ISO date formats (or at least something like |
|
I'm working on tidying this up. |
Some upstream repos use annoying version format like: 10.2-63.
When running through the service, : and - are deleted which generates
unusable/misleading version strings (10.263).
This patches adds an option (iso-cleanup-string) which allows to choose which charater/string
to use to replace the non iso ones.
Default value is '' which keeps the legacy behaviour.
For example
10.2-63 with iso-cleanup-string='.' will generate 10.2.63
A test is added to check the proper behavior of the option
Signed-off-by: Nicolas Morey-Chaisemartin [email protected]