Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more documentation for README.md #157

Merged
merged 1 commit into from
May 30, 2017
Merged

Conversation

M0ses
Copy link
Collaborator

@M0ses M0ses commented May 23, 2017

should fix #155 and #156

  • short description for each service
  • documenation about archive formats

README.md Outdated

### obscpio
The obscpio archive format is the new OBS specific archive format which used and generated by the [OBS Delta Store](http://openbuildservice.org/help/manuals/obs-reference-guide/cha.obs.architecture.html#delta_store) to store SCM changes in an incremental way.
It is used by the obs_scm service. A file <package>.obsinfo including useful information from your SCM system is generated, so you can access this data at buildtime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not 100% clear to me from this wording whether obs_scm generates obscpio files or whether it consumes them. It seems to suggest that they are generated elsewhere (by the delta store) and "used by" (i.e. consumed) by obs_scm, but I think that would be a misinterpretation which contradicts the information on obs_scm below. Any chance you could tweak the wording to clarify this?

README.md Outdated
It is used by the obs_scm service. A file <package>.obsinfo including useful information from your SCM system is generated, so you can access this data at buildtime.

### tar
The tar archive format is used to create a tarball and it is used by the services "tar" and "tar_scm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar thing here - if a file format is "used by" X, that could mean either X is generating files in that format or X is consuming files in that format which were generated by something else.

* short description for each service
* documenation about archive formats
@M0ses M0ses force-pushed the docu-enhancement branch from f11cf98 to 7aa9d0c Compare May 30, 2017 16:24
@M0ses
Copy link
Collaborator Author

M0ses commented May 30, 2017

@aspiers I hope the new version is a bit more clearer

Copy link
Member

@aspiers aspiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aspiers aspiers merged commit 7aa9d0c into openSUSE:master May 30, 2017
@mmohring
Copy link

mmohring commented May 31, 2017

Another case of undocumented obsinfo leads to local builds with osc not working, because obsinfo is not copied by osc. Not sure if this belongs to this issue. Another case is that obs_scm services are also not working with osc because osc cannot handle the interface of this service, e.g. the pre build time source services setup. Dito for service type tar_scm. So it happens when you construct a service which needs to call a build time source service which needs for example obsinfo.

@aspiers
Copy link
Member

aspiers commented May 31, 2017

@mmohring Not sure I follow entirely but please do submit follow-up issues (or even better, PRs)! Thanks!

@M0ses M0ses deleted the docu-enhancement branch June 30, 2017 12:47
@aspiers
Copy link
Member

aspiers commented Oct 18, 2017

@mmohring Any chance you could submit a new issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obsinfo is undocumented
3 participants