Check path only if path reinstate successfully when reinstating path … #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by CLI We fail a path, and suspend the map which the path belongs to, then reinstate the path by CLI and it returned with a fail message, the problem is: 1) There is a lot of messages that indicate the path status is up but reinstate fail; 2) When we resume the map, the path change status to active from failed automatically though it's failed when we reinstated path before.
hreinecke
pushed a commit
that referenced
this pull request
Nov 28, 2016
Problem:
Multipathd segment faulty occured when device policy was configured in multipath.conf as follow:
#This is a device configuration just for COMPELNT device
devices {
device {
vendor COMPELNT
dev_loss_tmo 120
scheduler deadline
}
}
The call trace is:
Program received signal SIGSEGV, Segmentation fault.
0x00007f4eaaf49251 in __strstr_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x00007f4eaaf49251 in __strstr_sse2 () from /lib64/libc.so.6
#1 0x00007f4eabba879c in add_feature (f=f@entry=0x211b248, n=n@entry=0x7f4eabbc530a queue_if_no_path)
at structs.c:524
#2 0x00007f4eabba6993 in merge_hwe (src=0x2148c70, dst=0x211b220) at config.c:359
#3 factorize_hwtable (hw=0x214b800, n=n@entry=77) at config.c:452
#4 0x00007f4eabba7850 in load_config (file=file@entry=0x4144c8 /etc/multipath.conf) at config.c:651
#5 0x0000000000408959 in reconfigure (vecs=vecs@entry=0x2128ae0) at main.c:2078
#6 0x00000000004063c6 in child (param=0x0) at main.c:2483
#7 main (argc=<optimized out>, argv=<optimized out>) at main.c:2725
(gdb) up
#1 0x00007f4eabba879c in add_feature (f=f@entry=0x211b248, n=n@entry=0x7f4eabbc530a queue_if_no_path)
at structs.c:524
524 if (strstr(*f, n))
(gdb) p *f
= 0x0
Reasons:
When multipathd loads config, it will call merge_hwe() to merge the features between default_hw[] and config.
If the vender is not configured features in default_hw[], dst->features's value will be null. So strstr()'s first
parameter *f is null in add_feature(),too.
Signed-off-by: wei huang <[email protected]>
mwilck
pushed a commit
that referenced
this pull request
Aug 28, 2017
Problem:
Multipathd segment faulty occured when device policy was configured in multipath.conf as follow:
#This is a device configuration just for COMPELNT device
devices {
device {
vendor COMPELNT
dev_loss_tmo 120
scheduler deadline
}
}
The call trace is:
Program received signal SIGSEGV, Segmentation fault.
0x00007f4eaaf49251 in __strstr_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x00007f4eaaf49251 in __strstr_sse2 () from /lib64/libc.so.6
#1 0x00007f4eabba879c in add_feature (f=f@entry=0x211b248, n=n@entry=0x7f4eabbc530a queue_if_no_path)
at structs.c:524
#2 0x00007f4eabba6993 in merge_hwe (src=0x2148c70, dst=0x211b220) at config.c:359
#3 factorize_hwtable (hw=0x214b800, n=n@entry=77) at config.c:452
#4 0x00007f4eabba7850 in load_config (file=file@entry=0x4144c8 /etc/multipath.conf) at config.c:651
#5 0x0000000000408959 in reconfigure (vecs=vecs@entry=0x2128ae0) at main.c:2078
#6 0x00000000004063c6 in child (param=0x0) at main.c:2483
#7 main (argc=<optimized out>, argv=<optimized out>) at main.c:2725
(gdb) up
#1 0x00007f4eabba879c in add_feature (f=f@entry=0x211b248, n=n@entry=0x7f4eabbc530a queue_if_no_path)
at structs.c:524
524 if (strstr(*f, n))
(gdb) p *f
= 0x0
Reasons:
When multipathd loads config, it will call merge_hwe() to merge the features between default_hw[] and config.
If the vender is not configured features in default_hw[], dst->features's value will be null. So strstr()'s first
parameter *f is null in add_feature(),too.
Signed-off-by: wei huang <[email protected]>
(cherry picked from commit b1ecdd4)
|
This looks good to me. However, please resubmit to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by CLI
We fail a path, and suspend the map which the path belongs to, then reinstate the path by CLI and it returned with a fail message, the problem is: 1) There is a lot of messages that indicate the path status is up but reinstate fail; 2) When we resume the map, the path change status to active from failed automatically though it's failed when we reinstated path before.