Assemble without xmlbase #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow to preserve or discard xml:base attributes (XSLT parameter preserve-xmlbase: 1 = preserve xml:base, 0 = discard them) This addition was needed to avoid wrong image paths as the xml:base attribute is taken into account to construct the path.
Add $preserve-xmlbase XSLT parameter to preserve or discard xml:base attributes (default is to discard them)
fsundermeyer
added a commit
that referenced
this pull request
Aug 5, 2024
* Allow to preserve or discard xml:base attributes (XSLT parameter preserve-xmlbase: 1 = preserve xml:base, 0 = discard them) This addition was needed to avoid wrong image paths as the xml:base attribute is taken into account to construct the path. --------- Co-authored-by: Frank Sundermeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had problems image paths pointing to invalid parts. That was mainly due to having
xml:baseattributes inside the assembled bigfile. These attributes were taken into account when creating the image path.For an assembled bigfile, this isn't needed. This customization layer discards these
xml:baseattributes.