Atb transportation update #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/Azure Data Pipeline
|
@mheine3000 As new datasets added, we can upgrade the version to https://github.com/openEDI/open-data-access-tools/blob/master/oedi/__init__.py |
jgu2
reviewed
Feb 5, 2024
oedi/config.yaml
Outdated
Comment on lines
37
to
43
| - Identifier: atb_transportation | ||
| Name: oedi_atb_transportation | ||
| Locations: | ||
| - s3://oedi-data-lake/ATB/transportation/parquet/2022/fuels_marine | ||
| - s3://oedi-data-lake/ATB/transportation/parquet/2022/fuels | ||
| - s3://oedi-data-lake/ATB/transportation/parquet/2022/vehicles | ||
| - s3://oedi-data-lake/ATB/transportation/parquet/2022/vehicles_fuels |
There was a problem hiding this comment.
Just wondering, instead of adding atb_transportation, would we consider add Locations under atb directly? as they are all ATB datasets.
No tech issue as you put here, boths ways would work, a simple check your consideration of putting this way.
We need to update the version in |
added 2 commits
February 5, 2024 13:55
moto changed syntax in the recently released version 5, which broke our testing.
jgu2
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.