⬆️ [maykinmedia/open-api-framework#93] Security updates #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
Coperh
approved these changes
Jan 3, 2025
SonnyBA
reviewed
Jan 8, 2025
| set -ex | ||
|
|
||
| command -v uv || (echo "uv not found on PATH. Install it https://astral.sh/uv" >&2 && exit 1) | ||
|
|
||
| cwd="${PWD}" |
There was a problem hiding this comment.
I don't think we need cwd if we use toplevel in the pip-compile commands (as git rev-parse --show-toplevel returns an absolute path), for example
uv pip-compile \
--output-file "$toplevel/requirements/base.txt" \
"$@" \
"$toplevel/requirements/base.in"
You could also call it something like root_dir to make the variables purpose more descriptive.
Comment on lines
+1
to
+2
| -c ci.txt | ||
| -r ci.txt |
There was a problem hiding this comment.
Shouldn't this be done in the compile_dependencies script?
There was a problem hiding this comment.
It is like this in the default project and I also think its more correct since if you use pip install -r requirements/dev.in, it will install everything needed for dev vs before where it would just install those 5 libraries.
Though if you just want to install them, its less convenient but I cant think of a situation where I would.
Comment on lines
+1
to
+2
| -c base.txt | ||
| -r base.txt |
Comment on lines
+1
to
+2
| -c base.txt | ||
| -r base.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-api-framework#93 partially
Fixes maykinmedia/open-api-framework#81 partially
Changes