custom iframe app sends invalid ox_token
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `io.ox/core/tk/iframe` with the option `acquireToken`, the token is sent without being URL-encoded. Since the token is a base64 string, it should be URL-encoded.
|
Thanks for the PR. A colleague of mine will take care of this. Please note that this repository is a push-only mirror so we have to "cherry pick" your change by hand. |
|
Yes, thank you. |
|
External contributions via GitHub PR are totally fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
io.ox/core/tk/iframewith the optionacquireToken, the token is sent without being URL-encoded.Since the token is a base64 string, it should be URL-encoded.