Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use renovate, update CI and precommit #32

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

tagoro9
Copy link
Contributor

@tagoro9 tagoro9 commented Jul 5, 2024

Description

Modernize the action a bit with our latest standards and configs

Changes

  • ci: use renovate, update CI and precommit

🚀 PR created with fotingo

@tagoro9 tagoro9 requested a review from a team as a code owner July 5, 2024 16:30
@tagoro9 tagoro9 requested a review from greenkiwi July 5, 2024 16:30
@tagoro9 tagoro9 force-pushed the f/modernize_the_action branch from f5fc8cf to 023c4c5 Compare July 5, 2024 16:42
Copy link

github-actions bot commented Jul 5, 2024

Release notes preview

No new release will be created.

If you are expecting a release, you will need to either fix a bug or add a feature.
Chores, CI, docs, refactoring, style and other changes will not trigger a release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question about adding a push trigger to the CI job

Copy link
Contributor

@yohanb yohanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: mfinelli/setup-shfmt@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be part of actions-gha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could but not all require shfmt as it's part of pre-commit, so no sure

@tagoro9 tagoro9 merged commit 7a46c8d into main Sep 10, 2024
2 checks passed
@tagoro9 tagoro9 deleted the f/modernize_the_action branch September 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants