x component is in the x.tf or x-component/main.tf

[amazingandyyy]

Description

• add shell script to ensure component is defined inside the correct component.tf file OR parent-component/main.tf

Changes

• feat(hooks): check component is defined inside the correct component file

🚀 PR created with fotingo

[gopkri24]

Looks like it might be an outcome of RFC-288

[amazingandyyy]

@gopkri24 might have some overlap, but this is codify our existing standard for domain infra

[amazingandyyy]

I think your result proposal should consider backward compatible to the existing standard or come back to change the logic in the hook

[greenkiwi]

@amazingandyyy This seems too aggressive.

Do we really want this?

I could easily see a place where you had created a component in a directory

/systems/some-system/this-component/

And it would be really natural and probably right to put the component in the main.tf directory.

Maybe the check is ok in main, if in directory with component in it? Or maybe full path to file needs to have component in it?

[amazingandyyy]

@greenkiwi this script does allow component/main.tf case