Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade conventional-changelog-conventionalcommits #185

Merged

Conversation

tagoro9
Copy link
Contributor

@tagoro9 tagoro9 commented May 20, 2024

Description

This is breaking semantic-release.

See semantic-release/release-notes-generator#633

Changes

  • fix: downgrade conventional-changelog-conventionalcommits

🚀 PR created with fotingo

@tagoro9 tagoro9 requested a review from a team as a code owner May 20, 2024 13:37
@tagoro9 tagoro9 requested review from OmarJaroudi and Toolo May 20, 2024 13:37
@@ -9,7 +9,7 @@
"@semantic-release/github": "^10.0.3",
"@semantic-release/npm": "^12.0.0",
"@semantic-release/release-notes-generator": "^13.0.0",
"conventional-changelog-conventionalcommits": "^8.0.0",
"conventional-changelog-conventionalcommits": "^7.0.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think of adding a test that ensures that semantic-release works with this config. I may give it a try / file it as an issue in the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagoro9 tagoro9 force-pushed the b/downgrade_conventional_changelog_conventionalcommits branch from a9c2ae2 to a18e24d Compare May 20, 2024 13:42
Copy link

Release notes preview

Below is a preview of the release notes if your PR gets merged.


7.0.2 (2024-05-20)

Bug Fixes

  • downgrade conventional-changelog-conventionalcommits (a18e24d)

@tagoro9 tagoro9 merged commit 7731838 into main May 20, 2024
2 checks passed
@tagoro9 tagoro9 deleted the b/downgrade_conventional_changelog_conventionalcommits branch May 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants