Use consistent parserOpts for commit-analyzer and release-notes-generator #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea if we can back-port this as a patch to v1? Or will it just have to ship in v3 |
OmarJaroudi
force-pushed
the
b/try_fixing_config
branch
from
0c25fad to
c60f604
Compare
OmarJaroudi
changed the title
Toolo
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
I think backporting this would be ideal. We'd need to branch off the latest 1.x, 2.x releases and add them to the semantic release config for it to work: https://semantic-release.gitbook.io/semantic-release/usage/workflow-configuration#maintenance-branches
Would you like to try it out? 😄
PS: there's a snapshot test failing
tagoro9
approved these changes
Aug 23, 2023
|
now that we have a new semantic-release action we might not have to backport this after all 😄 |
OmarJaroudi
force-pushed
the
b/try_fixing_config
branch
from
5fce0ba to
90739fa
Compare
|
🎉 This PR is included in version 4.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per slack findings, we are passing these options to the release-notes-generator, but not to the commit-analyzer, which is why when using
BREAKINGorBREAKING CHANGES, you would see correct release notes but the version still ended up as a minorAfter discussing this with @tagoro9 offline, we agreed to let both the commit-analyzer and the release-notes-generator use the default parserOpts