test: add snapshot with compiled rule list #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...looks like the snapshot is failing due the parser line the config output being env specific... |
brantphoto
force-pushed
the
t/add-snapshot-with-rules
branch
from
cc887d9 to
0c5ea86
Compare
Release notes previewNo new release will be created. If you are expecting a release, you will need to either fix a bug or add a feature. |
|
fixed it! removed parser property from the snapshot and now the snapshot isn't env specific |
Toolo
approved these changes
Nov 27, 2024
|
@Toolo nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a snapshot of the compiled rules for this package.
pros:
now we can see which rules this package enables
cons:
perhaps harder to create a PR in github ui, as you'll have to update snapshots on change.