Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0 #334

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(deps): replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0 #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/breaking-changes/v13.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Breaking changes in v13

We are replacing `eslint-plugin-node` with `eslint-plugin-n`. See https://github.com/eslint-community/eslint-plugin-n

If you were reconfiguring some of the node rules in your eslint config you will have to update them:

```diff
- "node/no-missing-import": "off",
+ "n/no-missing-import": "off",
```
10 changes: 5 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = {
"import",
"jest",
"json",
"node",
"n",
"prettier",
"simple-import-sort",
"sonarjs",
Expand All @@ -27,7 +27,7 @@ module.exports = {
"plugin:import/typescript",
"plugin:jest/recommended",
"plugin:json/recommended-legacy",
"plugin:node/recommended",
"plugin:n/recommended",
"plugin:prettier/recommended",
"plugin:sonarjs/recommended-legacy",
"plugin:typescript-sort-keys/recommended",
Expand Down Expand Up @@ -61,14 +61,14 @@ module.exports = {
"import/prefer-default-export": "off",
"jest/no-jest-import": "off",
"json/*": "error",
"node/no-unpublished-import": [
"n/no-unpublished-import": [
"error",
{
allowModules: ["@jest/globals", "nock"],
},
],
"node/no-unsupported-features/es-syntax": "off",
"node/no-missing-import": "off",
"n/no-unsupported-features/es-syntax": "off",
"n/no-missing-import": "off",
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error",
"sort-destructure-keys/sort-destructure-keys": "error",
Expand Down
10 changes: 5 additions & 5 deletions legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
"import",
"jest",
"json",
"node",
"n",
"prettier",
"simple-import-sort",
"sonarjs",
Expand All @@ -27,7 +27,7 @@ module.exports = {
"plugin:import/typescript",
"plugin:jest/recommended",
"plugin:json/recommended-legacy",
"plugin:node/recommended",
"plugin:n/recommended",
"plugin:prettier/recommended",
"plugin:sonarjs/recommended-legacy",
"plugin:typescript-sort-keys/recommended",
Expand Down Expand Up @@ -62,14 +62,14 @@ module.exports = {
"import/prefer-default-export": "off",
"jest/no-jest-import": "off",
"json/*": "error",
"node/no-unpublished-import": [
"n/no-unpublished-import": [
"error",
{
allowModules: ["@jest/globals", "nock"],
},
],
"node/no-unsupported-features/es-syntax": "off",
"node/no-missing-import": "off",
"n/no-unsupported-features/es-syntax": "off",
"n/no-missing-import": "off",
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error",
"sort-destructure-keys/sort-destructure-keys": "error",
Expand Down
94 changes: 32 additions & 62 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"eslint-plugin-import": "2.31.0",
"eslint-plugin-jest": "28.9.0",
"eslint-plugin-json": "4.0.1",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-n": "14.0.0",
"eslint-plugin-prettier": "5.2.1",
"eslint-plugin-simple-import-sort": "12.1.1",
"eslint-plugin-sonarjs": "3.0.0",
Expand Down
110 changes: 55 additions & 55 deletions test/__snapshots__/test.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ exports[`validate config load config file in ESLint to validate all rules are co
"sonarjs",
"simple-import-sort",
"prettier",
"node",
"n",
"json",
"import",
"@typescript-eslint",
Expand Down Expand Up @@ -541,6 +541,60 @@ exports[`validate config load config file in ESLint to validate all rules are co
"multiline-ternary": [
"off",
],
"n/no-deprecated-api": [
"error",
],
"n/no-exports-assign": [
"error",
],
"n/no-extraneous-import": [
"error",
],
"n/no-extraneous-require": [
"error",
],
"n/no-missing-import": [
"off",
],
"n/no-missing-require": [
"error",
],
"n/no-process-exit": [
"error",
],
"n/no-unpublished-bin": [
"error",
],
"n/no-unpublished-import": [
"error",
{
"allowModules": [
"@jest/globals",
"nock",
],
},
],
"n/no-unpublished-require": [
"error",
],
"n/no-unsupported-features/es-builtins": [
"error",
],
"n/no-unsupported-features/es-syntax": [
"off",
{
"ignores": [],
},
],
"n/no-unsupported-features/node-builtins": [
"error",
],
"n/process-exit-as-throw": [
"error",
],
"n/shebang": [
"error",
],
"new-parens": [
"off",
],
Expand Down Expand Up @@ -691,9 +745,6 @@ exports[`validate config load config file in ESLint to validate all rules are co
"no-octal": [
"error",
],
"no-process-exit": [
"error",
],
"no-prototype-builtins": [
"error",
],
Expand Down Expand Up @@ -784,57 +835,6 @@ exports[`validate config load config file in ESLint to validate all rules are co
"no-wrap-func": [
"off",
],
"node/no-deprecated-api": [
"error",
],
"node/no-exports-assign": [
"error",
],
"node/no-extraneous-import": [
"error",
],
"node/no-extraneous-require": [
"error",
],
"node/no-missing-import": [
"off",
],
"node/no-missing-require": [
"error",
],
"node/no-unpublished-bin": [
"error",
],
"node/no-unpublished-import": [
"error",
{
"allowModules": [
"@jest/globals",
"nock",
],
},
],
"node/no-unpublished-require": [
"error",
],
"node/no-unsupported-features/es-builtins": [
"error",
],
"node/no-unsupported-features/es-syntax": [
"off",
{
"ignores": [],
},
],
"node/no-unsupported-features/node-builtins": [
"error",
],
"node/process-exit-as-throw": [
"error",
],
"node/shebang": [
"error",
],
"nonblock-statement-body-position": [
"off",
],
Expand Down
Loading