Skip to content

Commit

Permalink
fix: disable sonarjs/deprecation in legacy preset
Browse files Browse the repository at this point in the history
  • Loading branch information
OmarJaroudi committed Oct 21, 2024
1 parent e884ce8 commit ad86921
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions legacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ module.exports = {
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error",
"sort-destructure-keys/sort-destructure-keys": "error",
// Noisy rule - we may have helpers/methods that we mark as @deprecated but aren't planning to remove in the near future. This rule also significantly adds to eslint running time, which slows down both local development and CI.
"sonarjs/deprecation": "off",
// This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce.
"sonarjs/function-return-type": "off",
// We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.
Expand Down

0 comments on commit ad86921

Please sign in to comment.