Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prerelease): adds prerelease action that works on pull requests #32

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

greenkiwi
Copy link
Contributor

Description

Adds a new rerelease action that works against Pull Requests.

Changes

  • feat(prerelease): adds prerelease action that works on pull requests

🚀 PR created with fotingo

@greenkiwi greenkiwi force-pushed the add-prerelease-action branch from b0b0349 to ac11129 Compare January 14, 2024 09:24
Copy link
Contributor

@yohanb yohanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

runs:
using: composite
steps:
- name: Dump GitHub context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just really handy to have this when you're trying to see how various github actions are/aren't running, I don't think there's really a penalty to having it here.

exit 1
fi

echo "branch=$branch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the double echo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One echos the value so you can see it. The other is echoed into the GitHub file. So you don't know what was set.

issue-number: ${{ steps.PR.outputs.number }}
comment-author: "github-actions[bot]"
body-includes: "<!-- prerelease comment -->"
- name: Delete previous release note
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing line return

<!-- action-docs-description -->
## Description

< GitHub Action to compute a prerelease version based on the latest release version and the number of commits since the latest release. This will also generate a docker tag based on the computed version if the label `prerelease` is specified on the PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
< GitHub Action to compute a prerelease version based on the latest release version and the number of commits since the latest release. This will also generate a docker tag based on the computed version if the label `prerelease` is specified on the PR.
GitHub Action to compute a prerelease version based on the latest release version and the number of commits since the latest release. This will also generate a docker tag based on the computed version if the label `prerelease` is specified on the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is generated code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look and see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really weird that it's there. I'll remove it and see if it readds it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - it's some failure on the part of parsing the yaml to mkdown.

name: GitHub Action Release and Publish Prerelease Module
description: <
  GitHub Action to compute a prerelease version based on the latest release version and the number of commits since the
  latest release.

@greenkiwi greenkiwi force-pushed the add-prerelease-action branch from ac11129 to 5eedd2c Compare January 17, 2024 03:10
@greenkiwi greenkiwi merged commit 413b534 into main Jan 17, 2024
2 checks passed
@greenkiwi greenkiwi deleted the add-prerelease-action branch January 17, 2024 03:11
Copy link

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants