Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume semgrep checks by using running image as non-root user #9

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

prathamesh16c
Copy link
Contributor

@prathamesh16c prathamesh16c commented Aug 16, 2023

Unpauses semgrep checks, and run semgrep ci as a non-root user by using latest: nonroot semgrep image.

@prathamesh16c prathamesh16c requested a review from a team as a code owner August 16, 2023 18:58
@prathamesh16c prathamesh16c force-pushed the f/restart-semgrep-checks branch from 4610e25 to cbb92f0 Compare September 26, 2023 21:39
@prathamesh16c prathamesh16c linked an issue Sep 26, 2023 that may be closed by this pull request
@prathamesh16c prathamesh16c force-pushed the f/restart-semgrep-checks branch from 35ce9ce to 0983ba9 Compare September 26, 2023 21:47
@prathamesh16c prathamesh16c marked this pull request as draft September 26, 2023 21:47
@prathamesh16c prathamesh16c force-pushed the f/restart-semgrep-checks branch 2 times, most recently from b5f4d68 to ce1da14 Compare September 27, 2023 18:14
@prathamesh16c prathamesh16c force-pushed the f/restart-semgrep-checks branch from 4e09755 to 128a2cb Compare October 11, 2023 00:44
@prathamesh16c prathamesh16c marked this pull request as ready for review October 11, 2023 00:52
@prathamesh16c prathamesh16c changed the title feat: resume semgrep checks by using running image as non-root user Resume semgrep checks by using running image as non-root user Oct 11, 2023
@prathamesh16c prathamesh16c force-pushed the f/restart-semgrep-checks branch 2 times, most recently from c843426 to 0e9ef23 Compare January 31, 2024 19:08
@prathamesh16c prathamesh16c requested a review from tagoro9 January 31, 2024 21:32
Copy link
Contributor

@tagoro9 tagoro9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably simplify the way we are running the command inside docker

static-analysis/action.yaml Outdated Show resolved Hide resolved
@tagoro9 tagoro9 force-pushed the f/restart-semgrep-checks branch from ac2b8c0 to 137b823 Compare February 7, 2024 15:30
BREAKING CHANGE: unpause semgrep and run as non-root user

chore: update checkout to v4

chore: update readme
@prathamesh16c prathamesh16c force-pushed the f/restart-semgrep-checks branch from 817f37b to a9f0b07 Compare February 14, 2024 01:35
@prathamesh16c prathamesh16c merged commit a687e7d into main Feb 14, 2024
3 checks passed
@prathamesh16c prathamesh16c deleted the f/restart-semgrep-checks branch February 14, 2024 01:36
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Causes file ownership permission issues on github runner filesystem
2 participants