fix(static-analysis): fixing diff aware scanning for semgrep #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to review or approve. Testing the fix on this branch. |
prathamesh16c
requested changes
Dec 16, 2024
pkanoongo
force-pushed
the
semgrep_diffaware_fix
branch
from
6188872 to
022ebff
Compare
fix(static-analysis): fixing the failed checks fix(static-analysis): fixing the failed checks regarding gh token fix(static-analysis): fixing the failed checks fix(static-analysis): fixing the failed checkss fix(static-analysis): fixing the failed checkp fix(static-analysis): fixing the failed checkp format fix(static-anaysis): testing fix as suggested by semgrep team fix(static-anaysis): testing fix as suggested by semgrep team adding fetch depth fix(static-anaysis): testing fix as suggested by semgrep team adding fetch depth fix(static-anaysis): testing fix as suggested by semgrep team adding fetch depth fix(static-anaysis): adding fix suggested by semgrep support team
pkanoongo
force-pushed
the
semgrep_diffaware_fix
branch
from
022ebff to
de570a5
Compare
Release notes previewBelow is a preview of the release notes if your PR gets merged. 2.3.0 (2024-12-17)Features
Miscellaneous
|
|
All previous commits are squashed. |
prathamesh16c
approved these changes
Dec 17, 2024
prathamesh16c
approved these changes
Dec 17, 2024
tagoro9
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:-
During the testing, we identified that the semgrep is not running the diff aware scans instead it is currently scanning the entire repo. As per the semgrep diff aware documentation, our current setup might be failing because the diff-aware scanning requires a baseline reference to compare against the branch head. As the part of this fix, we are dynamically determining the baseline branch for each repository for semgrep to compare. Creating this branch to test and confirm the fix.
Fixes:-
/static-analysis/semgrep/action.yaml.