fix(static-analysis): unpausing and refractoring semgrep checks #37
Conversation
Release notes previewBelow is a preview of the release notes if your PR gets merged. 2.2.2 (2024-11-22)Bug Fixes
Miscellaneous
|
|
Updated the path on test. Both checks have passed. Thanks!! |
| @@ -21,6 +21,6 @@ jobs: | |||
| - uses: open-turo/actions-gha/test@v2 | |||
| with: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| - uses: ./static-analysis/semgrep | |||
| - uses: ./static-analysis | |||
There was a problem hiding this comment.
Updated the path here.
There was a problem hiding this comment.
@pkanoongo please can you create a retroactive breaking change doc in this repo and add instructions for the consuming repos on using the refactored path of this action.
There was a problem hiding this comment.
This is a new breaking change. Since the action definition when being used has to be changed and people will now get something like an action not found error.
Something like this in the previous v2
There was a problem hiding this comment.
I think there are 2 options:
- Keep the file name as is
- Create a breaking change and rename the file -> Maybe this one is better as that way consumers don't need to know that it's semgrep this action uses? (but if we add more tools running them in parallel will require refactoring the action so things can run in parallel)
There was a problem hiding this comment.
I think option2 is better. We will add instructions in our breaking change doc.
Description
The PR restructures the repo to move the semgrep workflow action from '/static-analysis/semgrep' to '/static-analysis'. All the references to the semgrep are updated to use the new path. Also, unpausing the semgrep checks.
Fixes