-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(gha): move OIDC config to the reusable workflow
BREAKING CHANGE: remove aws cli installation and credential configuration from consumer workflow
- Loading branch information
1 parent
83c63a1
commit a3c6170
Showing
3 changed files
with
86 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Breaking changes in v2 | ||
|
||
Move OIDC config to the reusable workflow | ||
|
||
## Description of changes | ||
|
||
The OIDC configuration has been moved to the reusable workflow. This change enable developers to use the OIDC configuration in multiple actions without duplicating the configuration. | ||
|
||
## Upgrade instructions | ||
|
||
Update from: | ||
|
||
``` | ||
permissions: | ||
id-token: write # This is required for requesting the JWT for OIDC | ||
contents: read | ||
... | ||
- name: Install aws cli | ||
run: | | ||
pip install awscli==1.33.21 | ||
aws --version | ||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
role-skip-session-tagging: true | ||
role-to-assume: ROLE-TO-ASSUME-WITH-OIDC | ||
aws-region: us-east-1 | ||
- name: Upload to S3 bucket | ||
uses: open-turo/actions-s3-artifact/upload@v1 | ||
id: aws-s3-upload | ||
with: | ||
compress: false | ||
path: PATH-TO-UPLOAD | ||
s3uri: S3-URI | ||
aws-region: us-east-1 | ||
``` | ||
|
||
to the following: | ||
|
||
``` | ||
- name: Upload to S3 bucket | ||
uses: open-turo/actions-s3-artifact/upload@v2 | ||
id: aws-s3-upload | ||
with: | ||
compress: false | ||
path: PATH-TO-UPLOAD | ||
s3uri: S3-URI | ||
aws-region: us-east-1 | ||
role-to-assume-with-oidc: ${{ ROLE-TO-ASSUME-WITH-OIDC }} # the role can be defined in the GHA Repository secrets or inline | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters