feat: adds lint-release-notes action #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagoro9
reviewed
Sep 12, 2023
semantic-release/src/index.ts
Outdated
| @@ -21,6 +21,8 @@ const OUTPUTS = { | |||
| new_release_major_version: "new-release-major-version", | |||
| new_release_minor_version: "new-release-minor-version", | |||
| new_release_patch_version: "new-release-patch-version", | |||
| last_release_version: "last-release-version", | |||
There was a problem hiding this comment.
Sort these alphabetically (not sure how the linter didn't pick this)
semantic-release/action.yaml
Outdated
| @@ -43,6 +43,12 @@ outputs: | |||
| new-release-patch-version: | |||
| description: "Patch version of the new release" | |||
| value: ${{ steps.semantic-release.outputs.new-release-patch-version }} | |||
| last-release-version: | |||
There was a problem hiding this comment.
Update the readme adding these to it (we haven't automated this - not sure if there is a way)
semantic-release/src/index.ts
Outdated
| if (nextRelease) { | ||
| setOutput(OUTPUTS.last_release_version, lastRelease.version); |
There was a problem hiding this comment.
Update the tests to check for these outputs
greenkiwi
force-pushed
the
add-prerelease-support
branch
from
008a92c to
def2346
Compare
Pull Request Test Coverage Report for Build 6193920728
💛 - Coveralls |
Toolo
approved these changes
Sep 13, 2023
greenkiwi
force-pushed
the
add-prerelease-support
branch
25 times, most recently
from
4809008 to
504725d
Compare
|
It seems the breaking changes comment shouldn't have been created though |
greenkiwi
force-pushed
the
f/add-last-release-outputs
branch
from
e1c21b7 to
875d39c
Compare
@tagoro9 it will break until it can self reference the updated version of semantic release Maybe there's a better way to do this. I'd copied how it was being done elsewhere. But it was good to pull the PRs apart. |
greenkiwi
force-pushed
the
add-prerelease-support
branch
from
67dfbd0 to
21b69b4
Compare
greenkiwi
force-pushed
the
add-prerelease-support
branch
15 times, most recently
from
3310c0b to
adbcde9
Compare
This adds a new check that enforces that a breaking changes document has been created.
greenkiwi
force-pushed
the
add-prerelease-support
branch
from
adbcde9 to
04e002a
Compare
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lint-release-notesaction that ensures that breaking change docs have been created and provides a preview of the release notes.actions-release/release-notes-preview🚀 PR created with fotingo