fix(semantic-release): run npm install inside the dist folder

open-turo · Sep 12, 2024 · 389c154 · 389c154
1 parent 9e2bc98
commit 389c154
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/semantic-release/dist/index.js b/semantic-release/dist/index.js
diff --git a/semantic-release/dist/index.js.map b/semantic-release/dist/index.js.map
diff --git a/semantic-release/src/index.ts b/semantic-release/src/index.ts
@@ -40,13 +40,16 @@ interface Inputs {
  * @param packages List of packages to install
  */
 async function runNpmInstall(packages: string[]) {
-  info(`Installing packages in ${path.resolve(__dirname, "..")}`);
+  // When the action is compiled with NCC this translates into the dist folder
+  // This is important so that there are no conflicts with any dev tool we are using
+  const installationPath = path.resolve(__dirname);
+  info(`Installing packages in ${installationPath}`);
   const silentFlag = process.env.RUNNER_DEBUG === "1" ? "" : "--silent";
   const data = await getExecOutput(
     "npm",
     ["install", ...packages, "--no-audit", silentFlag],
     {
-      cwd: path.resolve(__dirname, ".."),
+      cwd: path.resolve(installationPath),
     },
   );
   if (data.stderr !== "") {

diff --git a/semantic-release/test/index.test.ts b/semantic-release/test/index.test.ts
@@ -97,7 +97,7 @@ describe("semantic-release", () => {
         "--silent",
       ]
     `);
-    expect(options).toHaveProperty("cwd", expect.any(String));
+    expect(options).toHaveProperty("cwd", expect.stringContaining("/src"));
     expect(semanticReleaseMock).toHaveBeenCalledTimes(1);
     expect(semanticReleaseMock.mock.calls[0][0]).toMatchInlineSnapshot(`
       {