Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): allow to specify node version #44

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat(lint): allow to specify node version #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lint/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ This action runs the following lint checks:
| --- | --- | --- | --- |
| checkout-repo | Perform checkout as first step of action | `false` | true |
| github-token | GitHub token that can create/delete comments. Usually - 'secrets.GITHUB_TOKEN' | `true` | |
| node-version | Node version to use | `false` | 18 |
<!-- action-docs-inputs -->

<!-- action-docs-outputs -->
Expand Down
6 changes: 5 additions & 1 deletion lint/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ inputs:
github-token:
required: true
description: GitHub token that can create/delete comments. Usually - 'secrets.GITHUB_TOKEN'
node-version:
required: false
description: Node version to use
default: "18"
runs:
using: composite
steps:
Expand All @@ -18,7 +22,7 @@ runs:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: ${{ inputs.node-version }}
- name: Run npm ci if needed
if: hashFiles('package-lock.json') != ''
shell: bash
Expand Down
Loading