Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build-tools to 0.24.0 #820

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Update build-tools to 0.24.0 #820

merged 9 commits into from
Mar 28, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Mar 15, 2024 •
edited
Loading

Fixes #807

For the purpose of code review: Please review YAML changes - markdown files are autogenerated

Changes

  • update build-tools version to the next one (0.24.0 unreleased)
  • Adds stability to enum members
  • Add stability to a few experimental + deprecated attributes

Merge requirement checklist

@lmolkova lmolkova mentioned this pull request Mar 15, 2024
Closed
13 tasks
@lmolkova
Copy link
Contributor Author

lmolkova commented Mar 15, 2024 •
edited
Loading

Dear codeowners, please review md and yaml files in your area

Changes to pay special attention to:

  • all auto-generate attributes and metrics tables should have Stability column with a badge - make sure it matches your expectations.

Cosmetic changes:

  • Ordering now takes requirement level into consideration
  • Requirement Level is rendered slightly differently than before

@joaopgrassi
Copy link
Member

Can we run the tools and tackle each change in a separated PR? For example the sorting now changes a lot of things and it makes it hard to see what actually is a change vs what is just "cosmetic". I think that will make the review process easier.

@lmolkova
Copy link
Contributor Author

Can we run the tools and tackle each change in a separated PR? For example the sorting now changes a lot of things and it makes it hard to see what actually is a change vs what is just "cosmetic". I think that will make the review process easier.

Great idea, but it'd only be possible if I manually handcrafted each change. We wouldn't be able to merge them because the md check would fail.
I think going forward we should release build-tools more (maybe each substantial md change) so that we don't have enormous diffs.

@jsuereth
Copy link
Contributor

For the purpose of code review:

  1. Please review YAML changes
  2. Please ensure conflicts in Markdown are ok, but you can ignore the autogenerated portion as that's based on the tool.

@lmolkova lmolkova force-pushed the stability-everywhere branch from ea0c71a to c3197ea Compare March 25, 2024 18:36
@lmolkova lmolkova changed the title Build-tools 0.24.0: dry run Update build-tools to 0.24.0 Mar 25, 2024
@lmolkova lmolkova marked this pull request as ready for review March 25, 2024 18:42
@lmolkova lmolkova requested review from a team March 25, 2024 18:42
@lmolkova lmolkova requested a review from a team March 25, 2024 18:42
@lmolkova lmolkova force-pushed the stability-everywhere branch 2 times, most recently from bf5cc0f to 06125c5 Compare March 25, 2024 18:50
@lmolkova
Copy link
Contributor Author

//cc @open-telemetry/semconv-mobile-approvers @open-telemetry/semconv-system-approvers @open-telemetry/semconv-jvm-approvers @open-telemetry/semconv-k8s-approvers @open-telemetry/semconv-container-approvers @open-telemetry/semconv-http-approvers @open-telemetry/semconv-dotnet-approver

could you please review the yaml file changes for your area? Thanks!

@joaopgrassi
Copy link
Member

Thank you for working on this! It's a big milestone 🚀

@lmolkova lmolkova mentioned this pull request Mar 26, 2024
Merged
@lmolkova lmolkova force-pushed the stability-everywhere branch from 454e49f to f7400e3 Compare March 26, 2024 21:53
@gregkalapos gregkalapos mentioned this pull request Mar 27, 2024
Merged
3 tasks
trisch-me
trisch-me approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@trisch-me trisch-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

@lmolkova lmolkova force-pushed the stability-everywhere branch from 7164ee6 to 9fbb3b8 Compare March 27, 2024 16:30
ChrsMark
ChrsMark approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmolkova lmolkova force-pushed the stability-everywhere branch from 9fbb3b8 to b3f0d43 Compare March 27, 2024 16:50
@lmolkova
Copy link
Contributor Author

lmolkova commented Mar 27, 2024 •
edited
Loading

@jack-berg @trask @jonatan-ivanov @mateuszrzeszutek could you please check JVM-related yaml changes in this PR? 👍

@lmolkova
Copy link
Contributor Author

@JamesNK @noahfalk @antonfirsov could you please check dotnet-related yaml changes in this PR?

@lmolkova
Copy link
Contributor Author

@nachoBonafonte @LikeTheSalad @bryce-b @breedx-splk @surbhiia could you please check mobile-related yaml changes in this PR?

@lmolkova lmolkova force-pushed the stability-everywhere branch from b3f0d43 to 6d9a324 Compare March 27, 2024 17:08
@joaopgrassi
Copy link
Member

Sorry for the conflicts, I somehow forgot we were waiting for this 🙈. Got a bit too excited in moving things to the registry 😅

@lmolkova lmolkova force-pushed the stability-everywhere branch from 6d9a324 to 17abf81 Compare March 27, 2024 19:50
jack-berg
jack-berg approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JVM stuff looks good to me.

noahfalk
noahfalk approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet-aspnetcore.yaml, dotnet-kestrel.yaml, and dotnet-signalr.yaml all look fine to me. Were there any other files that are applicable to dotnet?

@lmolkova
Copy link
Contributor Author

@noahfalk this should be it. Thank you!

@breedx-splk
Copy link
Contributor

model/logs/mobile-events.yaml and mobile/events.md both look good to me. 👍🏻

@lmolkova lmolkova force-pushed the stability-everywhere branch from d644088 to 71ad879 Compare March 28, 2024 19:05
@lmolkova lmolkova merged commit a04a1f4 into open-telemetry:main Mar 28, 2024
11 checks passed
This was referenced Mar 29, 2024
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@jack-berg jack-berg jack-berg approved these changes

@pyohannes pyohannes pyohannes approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@trisch-me trisch-me trisch-me approved these changes

@noahfalk noahfalk noahfalk approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@joaopgrassi joaopgrassi

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking semconv build-tools 0.24.0 release readiness and roll out plan
10 participants
@lmolkova @joaopgrassi @jsuereth @breedx-splk @AlexanderWert @noahfalk @trisch-me @ChrsMark @pyohannes @jack-berg