-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Mention JavaAgent v2.0.0 default behaviour #1533
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,9 @@ updated to the stable HTTP semantic conventions, they: | |
- May drop the environment variable in their next major version and emit only | ||
the stable HTTP and networking conventions. | ||
|
||
The OpenTelemetry Java Agent [v2.0.0](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v2.0.0) and later already defaults to the stable | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for the clarification! should this text belong in the javaagent docs? I believe this doc is intended for instrumentation authors and telemetry backends rather than the end-users of specific instrumentation. I don't mind having it here either, but then I think we need a section for instrumentation-specific behavior that would initially contain Java instrumentation agent. Curious what @trask thinks. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I think that would probably be a better place, until we solve the more general questions in #534 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to @TylerHelmuth in #534, I would probably not have stumbled upon this info in the Java agent docs, since I was (via web search and general reading about metrics and their attributes) coming from the semconv docs. |
||
conventions -- you do not have to opt into them. | ||
|
||
## Summary of changes | ||
|
||
This section summarizes the changes made to the HTTP semantic conventions | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this whole section above is adding to the confusion. It was a good part of the blog post, but I wonder if the document here should just focus on the summary of changes?