-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add origin_referrer_url
, origin_url
and zone_identifier
to the file attribute
#1430
Open
AsuNa-jp
wants to merge
31
commits into
open-telemetry:main
Choose a base branch
from
AsuNa-jp:file_originevents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
968e8c2
add modified registry.yaml and generated files
AsuNa-jp ec834e6
add changelog
AsuNa-jp 160b7ee
reflect the feedback
AsuNa-jp 37c9710
reflect the feedback
AsuNa-jp 4a2fed9
format fix
AsuNa-jp 481bd1c
Merge branch 'main' into file_originevents
AsuNa-jp a2b4b35
Merge branch 'main' into file_originevents
AsuNa-jp 4b11936
Merge branch 'main' into file_originevents
AsuNa-jp a1a4867
Merge branch 'main' into file_originevents
AsuNa-jp e8256e6
add file.zone_identifier
AsuNa-jp c55cb2b
Merge branch 'file_originevents' of github.com:AsuNa-jp/semantic-conv…
AsuNa-jp 130bf61
re-generated the docs
AsuNa-jp 1f6663a
Merge branch 'main' into file_originevents
AsuNa-jp 329df10
Merge branch 'main' into file_originevents
trisch-me ba508e4
Merge branch 'main' into file_originevents
AsuNa-jp f4ad750
Merge branch 'main' into file_originevents
AsuNa-jp d82f261
add note of zoneID
AsuNa-jp c6b8d78
Merge branch 'file_originevents' of github.com:AsuNa-jp/semantic-conv…
AsuNa-jp b0016f6
Merge branch 'main' into file_originevents
AsuNa-jp 7d5331c
Merge branch 'open-telemetry:main' into file_originevents
AsuNa-jp ed796cc
fixed the typo
AsuNa-jp f4e241c
Merge branch 'main' into file_originevents
AsuNa-jp 264fd13
Merge branch 'main' into file_originevents
AsuNa-jp b590595
Merge branch 'main' into file_originevents
AsuNa-jp 0793ef9
Merge branch 'main' into file_originevents
AsuNa-jp 17107e4
Merge branch 'main' into file_originevents
AsuNa-jp a3dfd75
Merge branch 'main' into file_originevents
AsuNa-jp daa081e
Merge branch 'main' into file_originevents
AsuNa-jp 22d06ab
Merge branch 'main' into file_originevents
AsuNa-jp 088e959
resolve merge conflicts
AsuNa-jp 358f21a
Merge branch 'main' into file_originevents
AsuNa-jp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
# | ||
# If your change doesn't affect end users you should instead start | ||
# your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
component: file | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: add file.origin_referrer_url, file.origin_url, and file.zone_identifier | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
# The values here must be integers. | ||
issues: [1430] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
file.windows_zone.id
?Given the generic nature of the word of 'zone' I think this should be clarified. Additionally we should stick to a similar convention across otel for
id
, and we don't useidentifier
anywhere else that I'm aware of.