Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accepted exporters in SDK configuration #5733

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

macno
Copy link
Contributor

@macno macno commented Dec 5, 2024

Add missing console exporter to the accepted list of exporters in all signals.
Also add a note in the description that the value may be a comma-separated list

@macno macno changed the title WIP Update general.md Update accepted exporters in SDK configuration Dec 5, 2024
@macno macno marked this pull request as ready for review December 5, 2024 10:32
@macno macno requested a review from a team as a code owner December 5, 2024 10:32
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@cartermp
Copy link
Contributor

cartermp commented Dec 6, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12192816510

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@cartermp cartermp enabled auto-merge December 7, 2024 05:20
@cartermp cartermp added this pull request to the merge queue Dec 7, 2024
Merged via the queue into open-telemetry:main with commit 1e4970e Dec 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants