Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix service version and name correspondence to build-info.properties #5712

Merged
merged 3 commits into from
Dec 4, 2024
Merged

docs: fix service version and name correspondence to build-info.properties #5712

merged 3 commits into from
Dec 4, 2024

Conversation

sergimola
Copy link
Contributor

The service name and version were switched in the docs.

Before ❌
service.name --> build.version
service.version --> build.name

After ✅
service.name --> build.name
service.version --> build.version

@sergimola sergimola requested a review from a team as a code owner December 2, 2024 09:44
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 2, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: opentelemetrybot / name: OpenTelemetry Bot (87f4100)
  • ✅ login: sergimola (234e668)
  • ✅ login: svrnm / name: Severin Neumann (f05f05a)

@opentelemetrybot opentelemetrybot requested review from a team December 2, 2024 09:45
@opentelemetrybot opentelemetrybot requested a review from a team December 2, 2024 19:06
@svrnm
Copy link
Member

svrnm commented Dec 4, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12156041734

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm svrnm added this pull request to the merge queue Dec 4, 2024
Merged via the queue into open-telemetry:main with commit ba2d1c4 Dec 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger zeitlinger approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
sig:java
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergimola @svrnm @opentelemetrybot @zeitlinger