Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java config docs for OTLP endpoint #5709

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

jaydeluca
Copy link
Member

Context

My intent is to clarify the configuration options for the otel.exporter.otlp.endpoint configuration option. I think the current description could be interpreted to mean that It is needed to supply the v1/{signal} postfix for the endpoint, when that is only required when using the otel.exporter.otlp.{signal}.endpoint option.

What is being changed

Updated description for otel.exporter.otlp.endpoint removing references to the v1/{signal} postfix, and updated the reference to the default value of http://localhost:4318 instead of http://localhost:4318/v1/{signal}

Updated the description for otel.exporter.otlp.{signal}.endpoint to include the note about needing to include the postfix to the provided endpoint

@jaydeluca jaydeluca requested a review from a team as a code owner November 30, 2024 20:00
@opentelemetrybot opentelemetrybot requested review from a team November 30, 2024 20:00
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this helps to clarify the settings. Thanks @jaydeluca !

@opentelemetrybot opentelemetrybot requested review from a team December 3, 2024 22:30
@svrnm svrnm added this pull request to the merge queue Dec 4, 2024
Merged via the queue into open-telemetry:main with commit e7dea82 Dec 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants