Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registry version updater #5685

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix registry version updater #5685

merged 2 commits into from
Dec 3, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Nov 26, 2024

The workflow to update versions in the registry was broken due to some errors introduced by PHP packages missing the open-telemetry prefix. I fixed those files, but also introduced 2 additional changes:

  • A way to catch errors if getting the latest version for a package fails, so a situation like this will not break the workflow again
  • A way to check if any versions have been updated and only if a new PR will be created, otherwise the script will always terminate with error

@svrnm svrnm requested a review from a team as a code owner November 26, 2024 08:40
tiffany76
tiffany76 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@svrnm
fix CI
19a3f6f 
Signed-off-by: svrnm <[email protected]>
@svrnm svrnm added this pull request to the merge queue Dec 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2024
@svrnm
Fix registry version updater (#5685)
f5e970c 
Signed-off-by: svrnm <[email protected]>
Merged via the queue into open-telemetry:main with commit f5e970c Dec 3, 2024
18 checks passed
@svrnm svrnm deleted the fix-registry-version-updater branch December 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
registry
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svrnm @tiffany76