Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Translate concepts/instrumentation-scope #5604

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

vitorvasc
Copy link
Contributor

Fixes #4922

  • Add new translations:
    • content/pt/docs/concepts/instrumentation-scope/index.md

@vitorvasc vitorvasc requested a review from a team as a code owner November 13, 2024 13:02
@opentelemetrybot opentelemetrybot requested review from a team November 13, 2024 13:02
@chalin chalin force-pushed the ptbr_translate_concepts_instrumentation_scope branch from 7e4d0ee to cf8dfc4 Compare November 13, 2024 14:12
Copy link
Contributor

@EzzioMoreira EzzioMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@opentelemetrybot opentelemetrybot requested a review from a team November 22, 2024 15:06
@vitorvasc
Copy link
Contributor Author

@maryliag perfeito! obrigado pelas sugestões 🚀

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu que agradeço sua contribuição!
LGTM

@vitorvasc
Copy link
Contributor Author

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11975457924

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@opentelemetrybot opentelemetrybot requested a review from a team November 25, 2024 00:45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin I think images do not need to be copied, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it makes sense to keep the original source!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm @chalin Uhh, the original image is located on content/en/docs/concepts/instrumentation-scope/spans-with-instrumentation-scope.svg.

Shall we move it to the /static/img folder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I know if you leave it out it will be picked from the en version but I am not 100% sure about that. @chalin knows best but is out of office until early next week, let's give him some time to take a look and respond

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! No worries. Thanks @svrnm :)

@opentelemetrybot opentelemetrybot requested review from a team November 28, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review Required
Status: No status
Development

Successfully merging this pull request may close these issues.

[pt] Portuguese page localization
7 participants