-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Zero code image #5409
Added Zero code image #5409
Conversation
Hi @svrnm, I'm having trouble displaying the image. I checked most of the markdown files in the project, and it seems that images are added using this syntax: I'd appreciate your guidance on this. |
Do the following:
Can you use the SVG instead of the png? This allows us to edit the image in the future much easier and most modern browser render SVGs just fine. |
@svrnm here is my output locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress, thanks
@svrnm I have addressed your comments. |
@mercybassey thanks, this looks good! I asked @open-telemetry/docs-approvers to take a look as well, so that we have at least one more person to take a look |
Great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mercybassey.
@svrnm - I've commented on Slack. PTAL
@mercybassey apologies for the delay here. We need to discuss the details a little bit more before we can get this merged. This will unfortunately not happen before the end of the contribution phase for outreachy. So, assume this as "done" for your application and if you are still interested we can follow up later. |
Alright. I’m cool with that. Thanks. |
@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday! |
Great. Thank you. |
Unfortunately @chalin is out of office, I will follow up with him to talk this through to give you further feedback. Apologies for the further delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm - I defer to you on the acceptance of this image as is. Could we at least ensure that it is compatible with dark mode from the outset, which it currently is not:
Thanks! I think this image is a good starting point on which we can iterate. I agree that it should be compatible with dark mode as well, this is accomplished best with a transparent background @mercybassey please take a look |
Sure @svrnm. I'll adjust the image and use a transparent background instead. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. The contrast on the text and lines (outside of the boxes) isn't great -- it would require a wee bit more work to fix that and I don't have the time to explore a solution. In any case, this is quite good enough for now!
thank you for your contribution and your patience @mercybassey ! |
This PR adds an illustration for Open telemetry zero code.
Issue: #5354