Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Document logs #4463

Merged
merged 25 commits into from
May 16, 2024
Merged

[Go] Document logs #4463

merged 25 commits into from
May 16, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented May 10, 2024 •
edited
Loading

@pellared pellared marked this pull request as ready for review May 10, 2024 11:40
@pellared pellared requested review from a team May 10, 2024 11:40
@pellared pellared marked this pull request as draft May 10, 2024 11:51
@pellared pellared marked this pull request as ready for review May 10, 2024 11:53
chalin
chalin reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this reads well so far! I make a quick pass. See inline for preliminary copyedits.

content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/go/instrumentation.md Outdated Show resolved Hide resolved
@pellared pellared requested a review from chalin May 10, 2024 12:07
@pellared pellared requested a review from svrnm May 15, 2024 11:32
svrnm
svrnm approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall when @chalin's comments are addressed

@pellared pellared mentioned this pull request May 15, 2024
Closed
@pellared pellared requested a review from chalin May 15, 2024 17:17
@pellared
Copy link
Member Author

PTAL @open-telemetry/go-approvers

@svrnm svrnm merged commit 12f31f6 into open-telemetry:main May 16, 2024
15 checks passed
@pellared pellared deleted the go-logs branch May 16, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@dmathieu dmathieu dmathieu approved these changes

@chalin chalin Awaiting requested review from chalin

Assignees
No one assigned
Labels
sig:go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document slog log bridge [Go] Document logs
4 participants
@pellared @dmathieu @svrnm @chalin