Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit option for SDK otlp exporter to disable retry #4148

Closed
wants to merge 1 commit into from
Closed

Add explicit option for SDK otlp exporter to disable retry #4148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion specification/protocol/exporter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,12 @@ The `OTEL_EXPORTER_OTLP_HEADERS`, `OTEL_EXPORTER_OTLP_TRACES_HEADERS`, `OTEL_EXP

## Retry

Transient errors MUST be handled with a retry strategy. This retry strategy MUST implement an exponential back-off with jitter to avoid overwhelming the destination until the network is restored or the destination has recovered.
Transient errors MUST be handled with a retry strategy. This retry strategy MUST
implement an exponential back-off with jitter to avoid overwhelming the
destination until the network is restored or the destination has recovered.

SDKs SHOULD provide a configuration option to disable the retry strategy. This
option MAY be named `disabled`, AND MUST be `false` by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the conditional interpretation of the required enablement.

Suggested change
option MAY be named `disabled`, AND MUST be `false` by default.
option MAY be named `disabled`. The retry strategy MUST be enabled by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only a MAY because of existing solutions? I felt it should be stronger, a SHOULD or even MUST since I'm pretty sure elsewhere in the spec defines that toggles like this must be something like disabled and not enabled.


### Transient errors

Expand Down
Loading