Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export MetricsExporterBuilder #943

Merged
merged 3 commits into from
Jan 15, 2023
Merged

export MetricsExporterBuilder #943

merged 3 commits into from
Jan 15, 2023

Conversation

bestgopher
Copy link
Contributor

No description provided.

@bestgopher bestgopher requested a review from a team January 15, 2023 03:40
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 67.7% // Head: 67.7% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (f8d0014) compared to base (c3b1056).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #943   +/-   ##
=====================================
  Coverage   67.7%   67.7%           
=====================================
  Files        116     116           
  Lines       9120    9103   -17     
=====================================
- Hits        6176    6170    -6     
+ Misses      2944    2933   -11     
Impacted Files Coverage Δ
opentelemetry-api/src/global/error_handler.rs 42.1% <0.0%> (-2.9%) ⬇️
opentelemetry-datadog/src/exporter/mod.rs 25.1% <0.0%> (-0.5%) ⬇️
opentelemetry-zipkin/src/exporter/model/mod.rs 78.8% <0.0%> (-0.4%) ⬇️
...emetry-jaeger/src/exporter/config/collector/mod.rs 60.8% <0.0%> (-0.3%) ⬇️
opentelemetry-sdk/src/trace/span_processor.rs 83.3% <0.0%> (-0.1%) ⬇️
opentelemetry-sdk/src/trace/span.rs 93.5% <0.0%> (-0.1%) ⬇️
opentelemetry-zipkin/src/exporter/uploader.rs 0.0% <0.0%> (ø)
...c/trace/sampler/jaeger_remote/sampling_strategy.rs 0.0% <0.0%> (ø)
opentelemetry-jaeger/src/exporter/collector.rs 20.0% <0.0%> (+0.1%) ⬆️
...aeger/src/exporter/config/collector/http_client.rs 23.6% <0.0%> (+0.2%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think this PR just need to cargo fmt

@bestgopher
Copy link
Contributor Author

Good catch. I think this PR just need to cargo fmt

Done!

@jtescher jtescher merged commit b67a873 into open-telemetry:main Jan 15, 2023
@bestgopher
Copy link
Contributor Author

@jtescher @TommyCpp Could you update a new version to crates.io?

@TommyCpp
Copy link
Contributor

#934 I will publish one soon. There are some memory issues we want to tackle

@bestgopher
Copy link
Contributor Author

#934 I will publish one soon. There are some memory issues we want to tackle

OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants