-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix serialization/deserialization for u64 and "NaN" float fields in Metrics #2491
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2491 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 123 123
Lines 22944 22944
=====================================
Hits 17879 17879
Misses 5065 5065 ☔ View full report in Codecov by Sentry. |
…ntelemetry-rust into fix-metrics-u64-serialization
@nikhilsinhaparseable would it be possible for you to validate and confirm this PR against the issues mentioned in #2487 - It would be easy to get it merged in that case. Else, I will try adding unit-tests sometime next week. |
sure @lalitb let me validate this, i will get back to you by tomorrow. |
@lalitb histogram is fixed, I can see all the fields are getting serialized. |
@nikhilsinhaparseable Thanks for testing. Just to understand your use-case better - you are using opentelemetry-proto only to deserialize the data generated by otel collector? Or are you using opentelemetry-otlp as exporter to send to collector? |
@lalitb I am using opentelemetry-proto to deserialize the data exporting from otel collector to Parseable |
@lalitb do we have a fix for summary metric types? |
Fixes #2487
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes