Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal logging to HTTP libraries #2452

Merged

Conversation

cijothomas
Copy link
Member

Fixes #2446

It's now easy to debug, especially since tracing::fmt can also show the thread from which the calls are made!

2024-12-18T20:09:59.890413Z DEBUG tokio-runtime-worker opentelemetry_sdk:  name="PeriodicReaderWorker.InvokeExporter" Calling exporter's export method with collected metrics. count=1
2024-12-18T20:09:59.890457Z DEBUG tokio-runtime-worker opentelemetry-otlp:  name="HttpMetricsClient.CallingExport"
2024-12-18T20:09:59.890462Z DEBUG tokio-runtime-worker opentelemetry-http:  name="ReqwestClient.Send"

@cijothomas cijothomas requested a review from a team as a code owner December 18, 2024 20:18
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.1%. Comparing base (938893c) to head (7cd3c78).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-http/src/lib.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/http/metrics.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/http/trace.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2452     +/-   ##
=======================================
- Coverage   76.1%   76.1%   -0.1%     
=======================================
  Files        122     122             
  Lines      22056   22062      +6     
=======================================
  Hits       16790   16790             
- Misses      5266    5272      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas closed this Dec 19, 2024
@cijothomas cijothomas reopened this Dec 19, 2024
@cijothomas cijothomas merged commit 0a7ad69 into open-telemetry:main Dec 19, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internal logs for OTLP Http clients
2 participants