-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preallocate and keep memory for HashMap in Metric aggregation #2343
Merged
cijothomas
merged 11 commits into
open-telemetry:main
from
cijothomas:cijothomas/metric-pre-allocation
Nov 26, 2024
Merged
Preallocate and keep memory for HashMap in Metric aggregation #2343
cijothomas
merged 11 commits into
open-telemetry:main
from
cijothomas:cijothomas/metric-pre-allocation
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2343 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 123 123
Lines 21365 21371 +6
=======================================
+ Hits 17004 17008 +4
- Misses 4361 4363 +2 ☔ View full report in Codecov by Sentry. |
4 tasks
utpilla
reviewed
Nov 26, 2024
utpilla
reviewed
Nov 26, 2024
lalitb
reviewed
Nov 26, 2024
utpilla
approved these changes
Nov 26, 2024
4 tasks
pitoniak32
pushed a commit
to pitoniak32/opentelemetry-rust
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed originally in #2267 (comment)
and in #2288 (comment)
2 changes
These ensures HashMap never requires re-sizing in its lifetime.
Incremental changes only, as this is not quite the final state - we'll need to likely store the overflow outside of hashmap and also tackle #2328