Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hyper client for opentelemetry-otlp #2263

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 31, 2024

Fixes #1904

Changes

Enable hyper client for opentelemetry-otlp. And remove the custom hyper client from basic-otlp-http example.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 31, 2024 19:07
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (706a067) to head (bf25f22).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-http/src/lib.rs 0.0% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2263   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        121     121           
  Lines      20968   20978   +10     
=====================================
+ Hits       16660   16673   +13     
+ Misses      4308    4305    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla merged commit 3742953 into open-telemetry:main Nov 1, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add Hyper Client exporter for opentelemetry-otlp
3 participants