Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: InMemoryLogsExporter non plural #2258

Merged

Conversation

pitoniak32
Copy link
Contributor

related to comments:

Changes

De-pluralize Log Exporter types:

  • InMemoryLogsExporter -> InMemoryLogExporter
  • Fix rename on LogExporter Debug impl.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@pitoniak32 pitoniak32 requested a review from a team as a code owner October 28, 2024 13:06
@pitoniak32 pitoniak32 changed the title refactor: InMemoryLogsExporter and Builder non plural refactor: InMemoryLogsExporter non plural Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (17f4627) to head (973a8bd).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 92.3% 1 Missing ⚠️
opentelemetry-stdout/src/logs/exporter.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2258   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        121     121           
  Lines      20962   20962           
=====================================
+ Hits       16654   16656    +2     
+ Misses      4308    4306    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I believe it would be better to update the otel-sdk changelog even if the exporter is meant for testing, as done for metrics in #2255.

@cijothomas cijothomas merged commit 1b2d841 into open-telemetry:main Oct 29, 2024
22 of 23 checks passed
@pitoniak32 pitoniak32 deleted the refactor/log-exporters-non-plural branch November 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants